Skip to content

Conversation

alan-agius4
Copy link
Contributor

refactor(server): remove legacy URL handling logic

BREAKING CHANGE:

Legacy handling or Node.js URL parsing has been removed from ServerPlatformLocation.

The main differences are;

  • pathname is always suffixed with a /.
  • port is empty when http: protocol and port in url is 80
  • port is empty when https: protocol and port in url is 443

refactor(server): remove deprecated useAbsoluteUrl and baseUrl from PlatformConfig

BREAKING CHANGE: deprecated useAbsoluteUrl and baseUrl been removed from PlatformConfig. Provide and absolute url instead.

refactor(server): remove deprecated platformDynamicServer API

BREAKING CHANGE: deprecated platformDynamicServer has been removed. Add an import @angular/compiler and replace the usage with platformServer

refactor(server): remove deprecated ServerTransferStateModule API

BREAKING CHANGE: deprecated ServerTransferStateModule has been removed. TransferState can be use without providing this module.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Mar 15, 2024
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Mar 15, 2024
…le` API

BREAKING CHANGE: deprecated `ServerTransferStateModule` has been removed. `TransferState` can be use without providing this module.
BREAKING CHANGE: deprecated `platformDynamicServer` has been removed. Add an `import @angular/compiler` and replace the usage with `platformServer`
…seUrl` from `PlatformConfig`

BREAKING CHANGE: deprecated `useAbsoluteUrl` and `baseUrl` been removed from `PlatformConfig`. Provide and absolute `url` instead.
@alan-agius4 alan-agius4 force-pushed the remove-apis-deprecated branch from c678b4c to 4166a58 Compare March 15, 2024 10:34
@alan-agius4 alan-agius4 changed the title Remove apis deprecated Platform-server remove several deprecated APIs Mar 15, 2024
@alan-agius4 alan-agius4 added the area: server Issues related to server-side rendering label Mar 15, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 15, 2024
@alan-agius4 alan-agius4 added the refactoring Issue that involves refactoring or code-cleanup label Mar 15, 2024
BREAKING CHANGE:

Legacy handling or Node.js URL parsing has been removed from `ServerPlatformLocation`.

The main differences are;
  - `pathname` is always suffixed with a `/`.
  - `port` is empty when `http:` protocol and port in url is `80`
 - `port` is empty when `https:` protocol and port in url is `443`
This is following a number of cleanups.
@alan-agius4 alan-agius4 force-pushed the remove-apis-deprecated branch from 4166a58 to 97cba0b Compare March 15, 2024 10:46
@alan-agius4 alan-agius4 marked this pull request as ready for review March 15, 2024 10:47
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 15, 2024
@AndrewKushnir AndrewKushnir changed the title Platform-server remove several deprecated APIs Platform-server: remove several deprecated APIs Mar 15, 2024
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4 thanks for the cleanup 👍

@pullapprove pullapprove bot requested a review from AndrewKushnir March 15, 2024 22:38
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from jessicajaniuk March 15, 2024 22:38
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 15, 2024
@alxhub
Copy link
Member

alxhub commented Mar 18, 2024

This PR was merged into the repository by commit e0b60ad.

@alxhub alxhub closed this in e8b588d Mar 18, 2024
alxhub pushed a commit that referenced this pull request Mar 18, 2024
…API (#54874)

BREAKING CHANGE: deprecated `platformDynamicServer` has been removed. Add an `import @angular/compiler` and replace the usage with `platformServer`

PR Close #54874
alxhub pushed a commit that referenced this pull request Mar 18, 2024
…seUrl` from `PlatformConfig` (#54874)

BREAKING CHANGE: deprecated `useAbsoluteUrl` and `baseUrl` been removed from `PlatformConfig`. Provide and absolute `url` instead.

PR Close #54874
alxhub pushed a commit that referenced this pull request Mar 18, 2024
BREAKING CHANGE:

Legacy handling or Node.js URL parsing has been removed from `ServerPlatformLocation`.

The main differences are;
  - `pathname` is always suffixed with a `/`.
  - `port` is empty when `http:` protocol and port in url is `80`
 - `port` is empty when `https:` protocol and port in url is `443`

PR Close #54874
alxhub pushed a commit that referenced this pull request Mar 18, 2024
This is following a number of cleanups.

PR Close #54874
@alan-agius4 alan-agius4 deleted the remove-apis-deprecated branch March 19, 2024 06:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering detected: breaking change PR contains a commit with a breaking change refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants