refactor(common): allow string urls in NgOptimizedImage input
#54901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
refactor/image-placeholder-url
branch
from
0969c97
to
96ab532
Compare
JeanMeche
force-pushed
the
refactor/image-placeholder-url
branch
from
96ab532
to
d7f8d2b
Compare
jessicajaniuk
added
the
area: common
AndrewKushnir
approved these changes
Apr 18, 2024
AndrewKushnir
added
action: review
AndrewKushnir
added
target: rc
kara
reviewed
May 6, 2024
|
I don't remember such a discussion, are we talking about pixel dimension or the image size (in kB) ? Either way, here are my thoughts:
|
|
@JeanMeche It's a requirement in the design doc (pinged you in the doc so you can see it). We didn't talk about it in any great detail, but the idea was to sanity check the dimensions (width/height). While it's true that dimensions != intrinsic size, we can still do a basic check. A placeholder that is 1000 x 1000 is egregious even if it's a simple image. |
With this commit it is now possible to pass an url as placeholder for the image directive.
JeanMeche
force-pushed
the
refactor/image-placeholder-url
branch
from
d7f8d2b
to
6f8a7a6
Compare
pullapprove
bot
requested review from
dylhunn,
pkozlowski-opensource and
thePunderWoman
| @@ -117,6 +117,11 @@ const FIXED_SRCSET_HEIGHT_LIMIT = 1080; | |||
| */ | |||
| export const PLACEHOLDER_BLUR_AMOUNT = 15; | |||
|
|
|||
| /** | |||
| * Placeholder dimension (height or width) limit to warn when the crossed. | |||
There was a problem hiding this comment.
Suggested change
| * Placeholder dimension (height or width) limit to warn when the crossed. | |
| * Placeholder dimension (height or width) limit in pixels. Angular produces a warning | |
| * when this limit is crossed. |
| * Warns if placeholder's dimension are over a threshold. | ||
| */ | ||
| function assertPlaceholderDimensions(dir: NgOptimizedImage, width: number, height: number) { | ||
| if (width > PLACEHOLDER_DIMENSION_LIMIT || height > PLACEHOLDER_DIMENSION_LIMIT) { |
There was a problem hiding this comment.
My understanding is that we want to check the size of a real placeholder image, not the width and height attribute values. @kara is that correct?
dylhunn
approved these changes
May 7, 2024
thePunderWoman
approved these changes
May 7, 2024
AndrewKushnir
added
target: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit it is now possible to pass an url as placeholder for the image directive.