Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate adev to use the control flow syntax #55015

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JeanMeche
Copy link
Member

Note: this commit does not update the first-app tutorial to the control flow as the video still reference *ngFor

@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 24, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 24, 2024
Copy link

github-actions bot commented Mar 24, 2024

Deployed adev-preview for d82d966 to: https://ng-dev-previews-fw--pr-angular-angular-55015-adev-prev-or56ikaf.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche force-pushed the docs/adev-control-flow branch 3 times, most recently from 3ab35e8 to f2539d4 Compare March 26, 2024 04:01
Note: this commit does not update the first-app tutorial to the control flow as the video still reference `*ngFor`
@JeanMeche JeanMeche marked this pull request as ready for review April 15, 2024 14:26
Copy link
Contributor

@twerske twerske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits on the else blocks and empty imports that the script didn't catch, but those can be follow up PRs

<span class="badge">{{ crisis.id }}</span>{{ crisis.name }}
</a>
</li>
@for (crisis of crises$ | async; track crisis) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@for (crisis of crises$ | async; track crisis) {
@for (crisis of crises$ | async; track crisis.id) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adev: preview area: docs Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants