docs: update links to the calling-compilecomponents section #55055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed adev-preview for c7e50e0 to: https://ng-dev-previews-fw--pr-angular-angular-55055-adev-prev-wzsqrc62.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
added
action: merge
atscott
added
target: minor
|
@amayer42 could you please rebase this PR? Looks like there are conflicts with other things that got merged |
|
@atscott hoping that I did it right, never really used rebase before. The commits look right to me now though, so fingers crossed. |
|
@atscott @JeanMeche , is there anything else that I need to do on this? Or does this just need @alxhub 's approval at this point? I just want to make sure that I'm not missing something. |
atscott
added
action: merge
atscott
approved these changes
Apr 5, 2024
atscott
pushed a commit
that referenced
this pull request
Apr 8, 2024
atscott
pushed a commit
that referenced
this pull request
Apr 8, 2024
|
This PR was merged into the repository by commit 2eb83c6. |
atscott
pushed a commit
that referenced
this pull request
Apr 8, 2024
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 11, 2024
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Clicking on links to the Calling compileComponents() section do not apply the correct fragment. Instead of "calling-compilecomponents" they set the fragment to "compile-components".
Issue Number: N/A
What is the new behavior?
I have updated links to the section to use "calling-compilecomponents" as the fragment instead of "compile-components".
Does this PR introduce a breaking change?