Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Remove unused change detection flags #55057

Closed
wants to merge 1 commit into from
Closed

refactor(core): Remove unused change detection flags #55057

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Mar 26, 2024

This commit removes unused change detection flags.

@atscott atscott added area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release labels Mar 26, 2024
@atscott atscott requested a review from alxhub March 26, 2024 20:05
@ngbot ngbot bot added this to the Backlog milestone Mar 26, 2024
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 28, 2024
@ngbot
Copy link

ngbot bot commented Mar 28, 2024

I see that you just added the action: merge label, but the following checks are still failing:
    failure conflicts with base branch "main"
    pending status "mergeability" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott
refactor(core): Remove unused change detection flags
f35336e 
This commit removes unused change detection flags.
@atscott
Copy link
Contributor Author

atscott commented Mar 28, 2024

presubmit

@atscott
Copy link
Contributor Author

atscott commented Mar 28, 2024

This PR was merged into the repository by commit ea2d425.

@atscott atscott closed this in ea2d425 Mar 28, 2024
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@atscott @ilirbeqirii
refactor(core): Remove unused change detection flags (angular#55057)
367f5a9 
This commit removes unused change detection flags.

PR Close angular#55057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atscott @alxhub