Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix build failures in patch branch #55064

Closed
wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

This commit fixes various issues that seem to cause the 17.3.x patch to be red for weeks:

  • ESlint checking a file for aio/tools that is not part of a tsconfig— hence an error is being reported.
  • Audit-web-app importing some Lighthouse APIs that aren't available under the given path.

(I've committed some automatic formatting apparently— but as long as it's passing—I won't bother reverting)

This commit fixes various issues that seem to cause the 17.3.x patch
to be red for weeks:

- Eslint checking a file for aio/tools that is not part of a tsconfig—
  hence an error is being reported.

- Audit-web-app importing some Lighthouse APIs that aren't available
  under the given path.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 27, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 27, 2024
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 27, 2024
@devversion devversion marked this pull request as ready for review March 27, 2024 11:51
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 27, 2024
@devversion
Copy link
Member Author

Note: Kristiyan's review should be sufficient— i'm just not listed in docs-infra as owner

@devversion devversion removed the request for review from jessicajaniuk March 27, 2024 11:57
@devversion
Copy link
Member Author

This PR was merged into the repository by commit adf3ee8.

devversion added a commit that referenced this pull request Mar 27, 2024
This commit fixes various issues that seem to cause the 17.3.x patch
to be red for weeks:

- Eslint checking a file for aio/tools that is not part of a tsconfig—
  hence an error is being reported.

- Audit-web-app importing some Lighthouse APIs that aren't available
  under the given path.

PR Close #55064
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
This commit fixes various issues that seem to cause the 17.3.x patch
to be red for weeks:

- Eslint checking a file for aio/tools that is not part of a tsconfig—
  hence an error is being reported.

- Audit-web-app importing some Lighthouse APIs that aren't available
  under the given path.

PR Close angular#55064
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project PullApprove: disable target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants