New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix build failures in patch branch #55064
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes various issues that seem to cause the 17.3.x patch to be red for weeks: - Eslint checking a file for aio/tools that is not part of a tsconfig— hence an error is being reported. - Audit-web-app importing some Lighthouse APIs that aren't available under the given path.
angular-robot
bot
added
the
area: build & ci
Related the build and CI infrastructure of the project
label
Mar 27, 2024
devversion
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
target: patch
This PR is targeted for the next patch release
labels
Mar 27, 2024
devversion
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Mar 27, 2024
crisbeto
approved these changes
Mar 27, 2024
Note: Kristiyan's review should be sufficient— i'm just not listed in docs-infra as owner |
This PR was merged into the repository by commit adf3ee8. |
devversion
added a commit
that referenced
this pull request
Mar 27, 2024
This commit fixes various issues that seem to cause the 17.3.x patch to be red for weeks: - Eslint checking a file for aio/tools that is not part of a tsconfig— hence an error is being reported. - Audit-web-app importing some Lighthouse APIs that aren't available under the given path. PR Close #55064
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
This commit fixes various issues that seem to cause the 17.3.x patch to be red for weeks: - Eslint checking a file for aio/tools that is not part of a tsconfig— hence an error is being reported. - Audit-web-app importing some Lighthouse APIs that aren't available under the given path. PR Close angular#55064
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: build & ci
Related the build and CI infrastructure of the project
PullApprove: disable
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes various issues that seem to cause the 17.3.x patch to be red for weeks:
(I've committed some automatic formatting apparently— but as long as it's passing—I won't bother reverting)