fix(core): do not save point-in-time setTimeout and rAF references
#55124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
target: major
atscott
force-pushed
the
callbackscheduler
branch
from
ac888c6
to
f98bcec
Compare
Grabbing and saving the references to global `setTimeout` and `rAF` implementations at a certain point in time can be problematic, espcially in tests. Tests might call something like `jasmine.clock().install();` and `jasmine.clock().uninstall();`. If the install happens before we grab the implementation and then the uninstall happens after, our scheduling function will be broken because it would have saved a reference to the jasmine `setTimeout` implementation, which would have since been cleaned up and will throw an error when attempting to access `delayedFunctionScheduler`. There are other scenarios that may apply, not even just for tests, when patches are applied and removed to the globals.
atscott
force-pushed
the
callbackscheduler
branch
from
f98bcec
to
7fa8106
Compare
alxhub
approved these changes
Apr 1, 2024
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
This PR was merged into the repository by commit 840c375. |
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
angular#55124) Grabbing and saving the references to global `setTimeout` and `rAF` implementations at a certain point in time can be problematic, espcially in tests. Tests might call something like `jasmine.clock().install();` and `jasmine.clock().uninstall();`. If the install happens before we grab the implementation and then the uninstall happens after, our scheduling function will be broken because it would have saved a reference to the jasmine `setTimeout` implementation, which would have since been cleaned up and will throw an error when attempting to access `delayedFunctionScheduler`. There are other scenarios that may apply, not even just for tests, when patches are applied and removed to the globals. PR Close angular#55124
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grabbing and saving the references to global
setTimeoutandrAFimplementations at a certain point in time can be problematic, espcially in tests. Tests might call something likejasmine.clock().install();andjasmine.clock().uninstall();. If the install happens before we grab the implementation and then the uninstall happens after, our scheduling function will be broken because it would have saved a reference to the jasminesetTimeoutimplementation, which would have since been cleaned up and will throw an error when attempting to accessdelayedFunctionScheduler.There are other scenarios that may apply, not even just for tests, when patches are applied and removed to the globals.