Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform-browser): add withI18nSupport() in developer preview #55130

Closed
wants to merge 1 commit into from
Closed

feat(platform-browser): add withI18nSupport() in developer preview #55130

wants to merge 1 commit into from

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Mar 29, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 29, 2024
@devknoll devknoll force-pushed the x-refactor-provide-hydration branch 3 times, most recently from 94e0d84 to 3682566 Compare April 1, 2024 16:03
@devknoll devknoll marked this pull request as ready for review April 1, 2024 16:26
@pullapprove pullapprove bot requested a review from alxhub April 1, 2024 16:26
@devknoll devknoll force-pushed the x-refactor-provide-hydration branch from 3682566 to d984f2c Compare April 1, 2024 16:39
@AndrewKushnir AndrewKushnir changed the title feat(platform-browser): add withI18nHydration() in developer preview feat(platform-browser): add withI18nSupport() in developer preview Apr 1, 2024
@devknoll devknoll force-pushed the x-refactor-provide-hydration branch 3 times, most recently from 4b330eb to d92ea45 Compare April 1, 2024 20:20
@AndrewKushnir AndrewKushnir requested review from AndrewKushnir and jessicajaniuk and removed request for alxhub April 1, 2024 20:28
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release core: hydration labels Apr 1, 2024
@ngbot ngbot bot modified the milestone: Backlog Apr 1, 2024
AndrewKushnir
AndrewKushnir approved these changes Apr 2, 2024
View reviewed changes
adev/src/content/guide/hydration.md Outdated Show resolved Hide resolved
adev/src/content/guide/hydration.md Outdated Show resolved Hide resolved
packages/platform-browser/src/hydration.ts Show resolved Hide resolved
packages/platform-browser/src/hydration.ts Outdated Show resolved Hide resolved
@devknoll
feat(platform-browser): add withI18nSupport() in developer preview
075c711 
Expose withI18nSupport() as a hydration feature to enable i18n hydration
@devknoll devknoll force-pushed the x-refactor-provide-hydration branch from d92ea45 to 075c711 Compare April 2, 2024 02:19
@pullapprove pullapprove bot requested a review from dylhunn April 2, 2024 03:28
AndrewKushnir
AndrewKushnir approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Apr 2, 2024
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Apr 2, 2024 •
edited
Loading

Caretaker notes:

  • this PR would require landing this g3 patch first
  • the presubmit is "green" (only unrelated failing targets)

jessicajaniuk
jessicajaniuk approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 3, 2024
@ngbot
Copy link

ngbot bot commented Apr 3, 2024

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 45ae7a6.

@devknoll devknoll deleted the x-refactor-provide-hydration branch April 3, 2024 17:37
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@devknoll @ilirbeqirii
feat(platform-browser): add withI18nSupport() in developer preview (a…
2bfd946 
…ngular#55130)

Expose withI18nSupport() as a hydration feature to enable i18n hydration

PR Close angular#55130
@devknoll devknoll mentioned this pull request Apr 16, 2024
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 4, 2024
henry-alakazhang pushed a commit to freelancer/angular that referenced this pull request Jun 19, 2024
@devknoll @henry-alakazhang
feat(platform-browser): add withI18nSupport() in developer preview (a…
c45b6ef 
…ngular#55130)

Expose withI18nSupport() as a hydration feature to enable i18n hydration

PR Close angular#55130
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: core Issues related to the framework runtime core: hydration detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devknoll @AndrewKushnir @jessicajaniuk