Ensure animations are flushed when ApplicationRef.tick happens #55132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: animations
area: core
atscott
requested review from
JeanMeche and
alxhub
and removed request for
crisbeto
atscott
force-pushed
the
animationsscheduler
branch
from
d3bbeee
to
70aae48
Compare
JeanMeche
reviewed
Mar 30, 2024
packages/animations/browser/src/render/transition_animation_engine.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Mar 30, 2024
packages/platform-browser/animations/async/src/async_animation_renderer.ts
Outdated
Show resolved
Hide resolved
JeanMeche
approved these changes
Mar 30, 2024
atscott
force-pushed
the
animationsscheduler
branch
6 times, most recently
from
ae49578
to
b4036d9
Compare
atscott
force-pushed
the
animationsscheduler
branch
from
b4036d9
to
1a5e4e1
Compare
atscott
force-pushed
the
animationsscheduler
branch
4 times, most recently
from
50579e0
to
1d6c438
Compare
atscott
force-pushed
the
animationsscheduler
branch
from
1d6c438
to
2f05242
Compare
…resh This change ensures that `ApplicationRef.tick` flushes animations by calling `rendererFactory2.end`. This might not have happened before if there were no views that needed to be refreshed. This is also likely to fix a potential regression caused by angular#53718 even in zone apps where animations don't get flushed when no views attached to ApplicationRef are dirty.
atscott
force-pushed
the
animationsscheduler
branch
from
2f05242
to
d215fb0
Compare
atscott
added
the
merge: caretaker note
|
merge assistance: Please help get this green and/or merge with pending reviews |
alxhub
reviewed
Apr 23, 2024
atscott
force-pushed
the
animationsscheduler
branch
from
d215fb0
to
a354e71
Compare
atscott
removed
action: merge
alxhub
approved these changes
Apr 23, 2024
…aded in zoneless Async animations currently works in Zones because the render factory promise resolve causes change detection to happen. fixes angular#54919
atscott
force-pushed
the
animationsscheduler
branch
from
a354e71
to
f8fbeba
Compare
|
This PR was merged into the repository by commit 9ab36cf. |
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Apr 24, 2024
… when loaded in zoneless (angular#55132)" This reverts commit 9ab36cf.
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Apr 24, 2024
…need refresh (angular#55132)" This reverts commit a07ea06.
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 24, 2024
… when loaded in zoneless (angular#55132)" This reverts commit 9ab36cf.
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 24, 2024
…need refresh (angular#55132)" This reverts commit a07ea06.
AndrewKushnir
added a commit
that referenced
this pull request
Apr 24, 2024
AndrewKushnir
added a commit
that referenced
this pull request
Apr 24, 2024
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 26, 2024
… need refresh (angular#55132)" (angular#55524) This reverts commit e3d5607.
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 26, 2024
…resh (angular#55132) This reverts commit e3d5607 - reapplies original changes.
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 26, 2024
…resh (angular#55132) This reverts commit e3d5607 - reapplies original changes.
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 26, 2024
…resh (angular#55132) This reverts commit e3d5607 - reapplies original changes.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1
fix(core): Ensure DOM removal happens when no app views need refresh
This change ensures that
ApplicationRef.tickflushes animations bycalling
rendererFactory2.end. This might not have happened before ifthere were no views that needed to be refreshed.
This is also likely to fix a potential regression caused by #53718 even
in zone apps where animations don't get flushed when no views attached
to ApplicationRef are dirty.
Commit 2
fix(animations): Ensure async animations applies changes when loaded in zoneless
Async animations currently works in Zones because the render factory
promise resolve causes change detection to happen.
fixes #54919