Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): remove container index from conditional instruction #55190

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 3, 2024

Stops passing in the containerIndex argument to the conditional instruction since it isn't being used anymore.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: compiler Issues related to `ngc`, Angular's template compiler labels Apr 3, 2024
@ngbot ngbot bot modified the milestone: Backlog Apr 3, 2024
@crisbeto crisbeto force-pushed the conditional-container-index branch from 5f678cf to 7948c39 Compare April 3, 2024 14:27
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-core

@crisbeto crisbeto force-pushed the conditional-container-index branch 2 times, most recently from 5fc8aa2 to 0b52f47 Compare April 3, 2024 14:51
@crisbeto crisbeto modified the milestones: Backlog, v18-candidates Apr 3, 2024
Stops passing in the `containerIndex` argument to the `conditional` instruction since it isn't being used anymore.
@crisbeto crisbeto force-pushed the conditional-container-index branch from 0b52f47 to 98b7020 Compare April 15, 2024 15:00
@crisbeto crisbeto marked this pull request as ready for review April 15, 2024 15:32
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 15, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 7d5bc1c.

iteriani pushed a commit to iteriani/angular that referenced this pull request Apr 18, 2024
…ngular#55190)

Stops passing in the `containerIndex` argument to the `conditional` instruction since it isn't being used anymore.

PR Close angular#55190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants