Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): invalid ImageKit quality parameter #55193

Closed
wants to merge 4 commits into from
Closed

fix(common): invalid ImageKit quality parameter #55193

wants to merge 4 commits into from

Conversation

johnnygerard
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #55192

What is the new behavior?

Placeholder URLs of this form:
https://ik.imagekit.io/demo/tr:w-30,q-20/medium_cafe_B1iTdD0C.jpg

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from atscott April 3, 2024 14:07
JeanMeche
JeanMeche approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for catching the issue and providing a fix !

@johnnygerard
Copy link
Contributor Author

Thank you @JeanMeche for your assistance. This was my first non-trivial pull request to an open source repository.

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Apr 3, 2024
@ngbot ngbot bot modified the milestone: Backlog Apr 3, 2024
@AndrewKushnir AndrewKushnir removed the request for review from atscott April 4, 2024 04:15
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Apr 4, 2024
thePunderWoman pushed a commit that referenced this pull request Apr 5, 2024
@johnnygerard @thePunderWoman
fix(common): invalid ImageKit quality parameter (#55193)
53427d8 
The current quality parameter is ignored by ImageKit.

PR Close #55193
thePunderWoman pushed a commit that referenced this pull request Apr 5, 2024
@johnnygerard @thePunderWoman
test(common): update ImageKit low quality test (#55193)
80d1094 
For commit cd911a8

PR Close #55193
thePunderWoman pushed a commit that referenced this pull request Apr 5, 2024
@johnnygerard @thePunderWoman
test(common): update ImageKit low quality test (#55193)
58e2f47 
For commit cd911a8

PR Close #55193
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 58e2f47.

@johnnygerard johnnygerard deleted the imagekit-loader branch April 5, 2024 15:36
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@johnnygerard @ilirbeqirii
fix(common): invalid ImageKit quality parameter (angular#55193)
b959ba9 
The current quality parameter is ignored by ImageKit.

PR Close angular#55193
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@johnnygerard @ilirbeqirii
test(common): update ImageKit low quality test (angular#55193)
73aca90 
For commit cd911a8

PR Close angular#55193
iteriani pushed a commit to iteriani/angular that referenced this pull request Apr 11, 2024
@johnnygerard @iteriani
fix(common): invalid ImageKit quality parameter (angular#55193)
b54befb 
The current quality parameter is ignored by ImageKit.

PR Close angular#55193
iteriani pushed a commit to iteriani/angular that referenced this pull request Apr 11, 2024
@johnnygerard @iteriani
test(common): update ImageKit low quality test (angular#55193)
6f41d7f 
For commit cd911a8

PR Close angular#55193
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@johnnygerard @thePunderWoman @JeanMeche @AndrewKushnir @jessicajaniuk