fix(core): ComponentFixture autoDetect feature works like production #55228
+75
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
detected: breaking change
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
2 times, most recently
from
e7739f3
to
d1b1e6c
Compare
This commit fully integrates the `autoDetect` feature into
`ApplicationRef.tick` without special handling for errors.
BREAKING CHANGE: The `autoDetect` feature of `ComponentFixture` will now
report errors to the `ErrorHandler`. Previously, these errors were
thrown in a `setTimeout`. The default behavior of `ErrorHandler` is to
simply log the error to console. This change may cause custom error
handlers to observe new failures that were previously unreported.
Tests which use `fakeAsync` and call `flush` to expect these errors in
`setTimeout` to be thrown synchronously will also need to provide an
`ErrorHandler` that rethrows the errors:
```
{
provide: ErrorHandler,
useValue: {
handleError(e: unknown) {
throw e;
},
},
};
```
atscott
force-pushed
the
componentfixtureautodetect_saneVersion
branch
2 times, most recently
from
61c7250
to
7ce2963
Compare
This commit shares the method of autoDetect for change detection between the zoneless and zone component fixture implementations. The difference is now limited to: * autoDetect is not optional with zoneless * detectChanges with zoneless is AppRef.tick while it is ChangeDetectorRef.detectChanges with zones. This should likely converge more in the future. Not going through AppRef.tick means that the zone fixture does not get guaranteed `afterRender` executions and does not get the rerunning behavior if the fixture is marked dirty by a render hook.
pkozlowski-opensource
added
the
area: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fully integrates the
autoDetectfeature intoApplicationRef.tickwithout special handling for errors.BREAKING CHANGE: The
autoDetectfeature ofComponentFixturewill now report errors to theErrorHandler. Previously, these errors were thrown in asetTimeout. The default behavior ofErrorHandleris to simply log the error to console. This change may cause custom error handlers to observe new failures that were previously unreported.