refactor(router): resolve view transition promise in a timeout when u… #55327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: router
target: patch
atscott
force-pushed
the
viewtransitionsmacrotask
branch
2 times, most recently
from
298de9f
to
68378ec
Compare
…nsupported Related to angular#51131, this change ensures that the router navigation exits the current event loop before rendering the route when the view transition feature is enabled, when the browser does not support view transitions.
atscott
force-pushed
the
viewtransitionsmacrotask
branch
from
68378ec
to
5ee25ae
Compare
AndrewKushnir
approved these changes
Apr 30, 2024
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
This PR was merged into the repository by commit 9366e17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nsupported
Related to #51131, this change ensures that the router navigation exits the current event loop before rendering the route when the view transition feature is enabled, when the browser does not support view transitions.