Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add primitives scope to scopes list #55369

Closed
wants to merge 1 commit into from

Conversation

thePunderWoman
Copy link
Contributor

This adds primitives as a valid scope type for commits.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • CI related changes

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman thePunderWoman added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 16, 2024
@ngbot ngbot bot modified the milestone: Backlog Apr 16, 2024
@pullapprove pullapprove bot requested a review from devversion April 16, 2024 19:29
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to the CONTRIBUTING.md file? Also consider core/primitives as a scope name

This adds primitives as a valid scope type for commits.
@thePunderWoman
Copy link
Contributor Author

Just a quick note: We decide not to add this scope for now, but we will revisit in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants