feat(router): withNavigationErrorHandler can convert errors to redi…
#55370
+91
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
dylhunn,
pkozlowski-opensource and
thePunderWoman
atscott
requested review from
AndrewKushnir
and removed request for
pkozlowski-opensource,
thePunderWoman and
dylhunn
pullapprove
bot
requested review from
dylhunn,
pkozlowski-opensource and
thePunderWoman
dylhunn
approved these changes
Apr 16, 2024
pkozlowski-opensource
approved these changes
Apr 17, 2024
…rects This commit adds the ability to return `RedirectCommand` from the error handler provided by `withNavigationErrorHandler`. This will prevent the error from being surfaced in the `events` observable of the Router and instead convert the error to a redirect. This allows developers to have more control over how the Router handles navigation errors. There are some cases when the application _does not_ want the URL to be reset when an error occurs. resolves angular#42915
atscott
force-pushed
the
errorHandlerRedirectFeature
branch
from
efe3240
to
e5479b7
Compare
AndrewKushnir
approved these changes
Apr 17, 2024
|
This PR was merged into the repository by commit 4a42961. |
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 18, 2024
…rects (angular#55370) This commit adds the ability to return `RedirectCommand` from the error handler provided by `withNavigationErrorHandler`. This will prevent the error from being surfaced in the `events` observable of the Router and instead convert the error to a redirect. This allows developers to have more control over how the Router handles navigation errors. There are some cases when the application _does not_ want the URL to be reset when an error occurs. resolves angular#42915 PR Close angular#55370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rects
This commit adds the ability to return
RedirectCommandfrom the error handler provided bywithNavigationErrorHandler. This will prevent the error from being surfaced in theeventsobservable of the Router and instead convert the error to a redirect. This allows developers to have more control over how the Router handles navigation errors. There are some cases when the application does not want the URL to be reset when an error occurs.resolves #42915