fix(core): make ActivatedRoute inject correct instance inside @defer blocks
#55374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
action: review
AndrewKushnir
force-pushed
the
defer_fix_54864
branch
2 times, most recently
from
443a0e6
to
da29094
Compare
1 task
atscott
approved these changes
Apr 17, 2024
atscott
reviewed
Apr 17, 2024
…er` blocks `RouterOutlet` uses a unique injector logic that returns a value that correspond to the `ActivatedRoute` token dynamically. This logic breaks when a component/directive/pipe that injects the `ActivatedRoute` is located within a `@defer` block, because defer creates an `EnvironmentInjector` instance, which doesn't have that dynamic logic. We've added some special handling of the `OutletInjector` in one of the previous commits, but it was incomplete and it was not covering cases when different routes use the same component. This commit updates defer logic to re-establish this dynamic behavior for `ActivatedRoute` by creating an instance of the `OutletInjector` when a parent injector was also an instance of `OutletInjector`. This fix is a short-term solution and longer term we should find a way to achieve the dynamic behavior that Router relies on, but without adding a special case logic into defer. Resolves angular#54864.
AndrewKushnir
force-pushed
the
defer_fix_54864
branch
from
da29094
to
70a9973
Compare
atscott
approved these changes
Apr 17, 2024
AndrewKushnir
added
action: merge
|
Caretaker note: presubmit is "green", this PR is ready for merge. |
|
This PR was merged into the repository by commit 9894278. |
alxhub
pushed a commit
that referenced
this pull request
Apr 22, 2024
…er` blocks (#55374) `RouterOutlet` uses a unique injector logic that returns a value that correspond to the `ActivatedRoute` token dynamically. This logic breaks when a component/directive/pipe that injects the `ActivatedRoute` is located within a `@defer` block, because defer creates an `EnvironmentInjector` instance, which doesn't have that dynamic logic. We've added some special handling of the `OutletInjector` in one of the previous commits, but it was incomplete and it was not covering cases when different routes use the same component. This commit updates defer logic to re-establish this dynamic behavior for `ActivatedRoute` by creating an instance of the `OutletInjector` when a parent injector was also an instance of `OutletInjector`. This fix is a short-term solution and longer term we should find a way to achieve the dynamic behavior that Router relies on, but without adding a special case logic into defer. Resolves #54864. PR Close #55374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RouterOutletuses a unique injector logic that returns a value that correspond to theActivatedRoutetoken dynamically. This logic breaks when a component/directive/pipe that injects theActivatedRouteis located within a@deferblock, because defer creates anEnvironmentInjectorinstance, which doesn't have that dynamic logic.We've added some special handling of the
OutletInjectorin one of the previous commits, but it was incomplete and it was not covering cases when different routes use the same component. This commit updates defer logic to re-establish this dynamic behavior forActivatedRouteby creating an instance of theOutletInjectorwhen a parent injector was also an instance ofOutletInjector.This fix is a short-term solution and longer term we should find a way to achieve the dynamic behavior that Router relies on, but without adding a special case logic into defer.
Resolves #54864.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?