feat(router): allow providing metadata in routes #55400
Open
+305
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Meta service directly exposes HTMLMetaElements, and therefore requires DOM emulation to use. In order to allow setting page metadata without DOM emulation, introduce support on the route, similar to title.
devknoll
force-pushed
the
x-add-route-meta
branch
from
8da0bed
to
7e3d967
Compare
|
friendly ping @AndrewKushnir |
dgp1130
reviewed
Apr 25, 2024
| * | ||
| * @publicApi | ||
| */ | ||
| export interface MetadataEntry { |
There was a problem hiding this comment.
Drive by: Doesn't TS' existing DOM APIs have this information? Would we use one of those types?
That might only contain properties and not attributes, but worth taking a look just to be sure.
There was a problem hiding this comment.
Worth looking into. This definition came from the Meta service.
|
How common will it be to define metadata on routes? I'm wondering if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Meta service directly exposes HTMLMetaElements, and therefore requires DOM emulation to use. In order to allow setting page metadata without DOM emulation, introduce support on the route, similar to title.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information