refactor(zone.js): use .toString() directly for improved tree shakability
#55412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgp1130
added
action: review
dgp1130
changed the title
Object.prototype.toString directly for improved tree shakability.toString() directly for improved tree shakability
dgp1130
force-pushed
the
zone-tree-shaking
branch
from
b61ab85
to
47c912d
Compare
atscott
approved these changes
Apr 19, 2024
|
Whoops, accidentally deleted the branch. |
…ved tree shakability These lines were not tree shakable by Closure Compiler because `.toString()` is special cased as a "pure" function eligible to eliminated if it's return value is unused. However `.toString.call` circumvents this and makes Closure Compiler think the function may have side effects. Switching to `.toString()` should be fine here as `process.toString()` in Node outputs `[object process]` so this should be safe. Presumably the original motivation for this roundabout approach was for type safety reasons which no longer apply as `_global` is `any`.
dgp1130
force-pushed
the
zone-tree-shaking
branch
from
47c912d
to
0920c9f
Compare
dgp1130
added
action: merge
AndrewKushnir
added
target: minor
|
This PR was merged into the repository by commit 3312727. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines were not tree shakable by Closure Compiler because
.toString()is special cased as a "pure" function eligible to eliminated if it's return value is unused. However.toString.callcircumvents this and makes Closure Compiler think the function may have side effects. Switching to.toString()should be fine here asprocess.toString()in Node outputs[object process]so this should be safe. Presumably the original motivation for this roundabout approach was for type safety reasons which no longer apply as_globalisany.At least I'm assuming the original reason was for type safety. @JiaLiPassion do you happen to have any historical context why we might have used
{}.toString.call? It appears to have already been that way when Zone.js was synced into angular/angular.