Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Replay events queued in the event contract. #55467

Closed
wants to merge 1 commit into from

Conversation

iteriani
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 22, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 22, 2024
@iteriani iteriani requested review from tbondwilkinson and removed request for ellenyuan April 22, 2024 18:24
@iteriani iteriani changed the title Replay events queued in the event contract. refactor(core): Replay events queued in the event contract. Apr 22, 2024
@pullapprove pullapprove bot requested a review from devversion April 22, 2024 19:11
@iteriani iteriani force-pushed the dispatcher2 branch 2 times, most recently from 2d9132c to fdcd86d Compare April 22, 2024 22:48
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iteriani looks great, just left a few comments.

packages/core/src/hydration/event_replay.ts Show resolved Hide resolved
packages/core/src/hydration/event_replay.ts Outdated Show resolved Hide resolved
packages/core/src/hydration/event_replay.ts Outdated Show resolved Hide resolved
packages/core/src/hydration/event_replay.ts Outdated Show resolved Hide resolved
packages/core/src/hydration/event_replay.ts Outdated Show resolved Hide resolved
packages/core/src/hydration/event_replay.ts Outdated Show resolved Hide resolved
packages/core/src/hydration/event_replay.ts Outdated Show resolved Hide resolved
packages/core/src/hydration/event_replay.ts Show resolved Hide resolved
packages/core/src/hydration/event_replay.ts Outdated Show resolved Hide resolved
packages/core/src/hydration/event_replay.ts Show resolved Hide resolved
@iteriani iteriani force-pushed the dispatcher2 branch 3 times, most recently from 049c6c1 to 69cd88c Compare April 23, 2024 18:06
@angular-robot angular-robot bot removed the detected: feature PR contains a feature commit label Apr 23, 2024
@AndrewKushnir AndrewKushnir added target: minor This PR is targeted for the next minor release area: core Issues related to the framework runtime core: hydration labels Apr 23, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 23, 2024
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Apr 23, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Apr 23, 2024

Caretaker note: this PR requires landing this CL first.

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Apr 23, 2024

Caretaker note:

  • Prerequisite CL has landed.
  • Presubmit is "green".
  • The "requires: TGP" label was added earlier, when this PR contained another commit to update JSAction code. The JSAction change has landed in a separate commit earlier, so the label is no longer relevant.
  • This PR is ready for merge.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit requires: TGP This PR requires a passing TGP before merging is allowed labels Apr 23, 2024
@pullapprove pullapprove bot added requires: TGP This PR requires a passing TGP before merging is allowed labels Apr 23, 2024
…tcher.

This should accomplish event replay during full page hydration.
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 23, 2024
@AndrewKushnir
Copy link
Contributor

For documentation purposes: there was a minor change to the key_code.ts from JSAction as a code optimization (to avoid including it into the client bundle). This code was moved to a separate PR (#55499), so no TGP is needed for this one.

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 811fe00.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: hydration merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants