Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): skip defer timers on the server #55480

Closed
wants to merge 1 commit into from
Closed

fix(core): skip defer timers on the server #55480

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Adds a check that disables the timer scheduling for placeholder and loading blocks on the server since the underlying timer will delay the server response.

Fixes #55475.

@crisbeto
fix(core): skip defer timers on the server
5e6ecf7 
Adds a check that disables the timer scheduling for `placeholder` and `loading` blocks on the server since the underlying timer will delay the server response.

Fixes angular#55475.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Apr 23, 2024
@crisbeto crisbeto marked this pull request as ready for review April 23, 2024 13:17
@ngbot ngbot bot modified the milestone: Backlog Apr 23, 2024
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 23, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 23, 2024
@alxhub
Copy link
Member

alxhub commented Apr 23, 2024

This PR was merged into the repository by commit 5948193.

alxhub pushed a commit that referenced this pull request Apr 23, 2024
@crisbeto @alxhub
fix(core): skip defer timers on the server (#55480)
8979fba 
Adds a check that disables the timer scheduling for `placeholder` and `loading` blocks on the server since the underlying timer will delay the server response.

Fixes #55475.

PR Close #55480
@alxhub alxhub closed this in 5948193 Apr 23, 2024
@crisbeto crisbeto mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Bug in @placeholder block causing delay in server-side rendering
3 participants
@crisbeto @alxhub @AndrewKushnir