Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate compiler-cli to prettier formatting #55485

Closed
wants to merge 1 commit into from
Closed

refactor: migrate compiler-cli to prettier formatting #55485

wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

Migrate formatting to prettier for compiler-cli from clang-format

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 23, 2024
@josephperrott josephperrott marked this pull request as ready for review April 23, 2024 15:59
@pullapprove pullapprove bot requested a review from alan-agius4 April 23, 2024 16:11
@pullapprove pullapprove bot requested a review from alan-agius4 April 23, 2024 16:14
alan-agius4
alan-agius4 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: tooling-cli-shared-api

@pullapprove pullapprove bot requested a review from alan-agius4 April 23, 2024 16:15
@alan-agius4 alan-agius4 removed their request for review April 23, 2024 16:16
@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed target: major This PR is targeted for the next major release labels Apr 29, 2024
@AndrewKushnir
Copy link
Contributor

@josephperrott FYI, there is a merge conflict with the main branch. Could you please rebase and resolve the conflict? Thank you.

@josephperrott
refactor: migrate compiler-cli to prettier formatting
2ae8de5 
Migrate formatting to prettier for compiler-cli from clang-format
@josephperrott josephperrott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 29, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 0d78a92.

AndrewKushnir pushed a commit that referenced this pull request Apr 29, 2024
@josephperrott @AndrewKushnir
refactor: migrate compiler-cli to prettier formatting (#55485)
89dfb24 
Migrate formatting to prettier for compiler-cli from clang-format

PR Close #55485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker PullApprove: disable target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josephperrott @AndrewKushnir @alan-agius4 @alxhub