Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update di-in-action.md #55489

Closed
wants to merge 1 commit into from
Closed

docs: Update di-in-action.md #55489

wants to merge 1 commit into from

Conversation

serpent5
Copy link
Contributor

No description provided.

@pullapprove pullapprove bot requested a review from dylhunn April 23, 2024 16:36
@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 23, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 23, 2024
bencodezen
bencodezen approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Appreciate the consistency applied to how factory and inject are explained in that section.

@bencodezen bencodezen added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Apr 25, 2024
@AndrewKushnir AndrewKushnir removed the request for review from dylhunn April 25, 2024 19:54
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 0dc4df8.

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@serpent5 @AndrewKushnir
docs: Update di-in-action.md (#55489)
a20cf31 
PR Close #55489
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@serpent5 @AndrewKushnir
docs: Update di-in-action.md (#55489)
9258160 
PR Close #55489
@serpent5 serpent5 deleted the patch-5 branch April 25, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencodezen bencodezen bencodezen approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serpent5 @AndrewKushnir @bencodezen