refactor(core): Omit listeners from out-of-zone scheduling when using… #55525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ZoneJS (angular#55492) In Angular today, a bound listener automatically marks the view for check. When using ZoneJS, these listeners are most often executed in the Angular Zone as well, so synchronization (`ApplicationRef.tick`) will eventually happen. _However_, developers can opt out of zone-patching for events in several ways, and often do this for very frequent listeners like `mousemove`, `resize`, and `scroll`. We do not want to break existing expectations that these are now "safe" events to have listeners for by automatically scheduling change detection regardless of whether the listener executed inside or outside the Angular zone. In contrast, in order for developers to more easily transition to zoneless, we need to be able to ensure that components which are using `OnPush` are, for the most part, compatible with zoneless as well. Because listeners automatically mark the component for check, developers using `OnPush` did not/do not need to also call `ChangeDetectorRef.markForCheck` or a similar API. Unfortunately, this means that we need to consider the listener callbacks as a notification to schedule a `tick` when Zoneless is enabled. In the future, we would like to have an opt-out for this (i.e. signal components) since it's not really how we _want_ things to work. Also includes the fix for angular#54919 that got reverted only because it was easier to revert the set of conflicting commits
atscott
added
action: merge
|
Caretaker note: this is a roll forward of changes that were reverted. These changes did not contribute to the g3 failures. |
AndrewKushnir
approved these changes
Apr 25, 2024
|
This PR was merged into the repository by commit bf8814c. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 25, 2024
… ZoneJS (#55492) (#55525) In Angular today, a bound listener automatically marks the view for check. When using ZoneJS, these listeners are most often executed in the Angular Zone as well, so synchronization (`ApplicationRef.tick`) will eventually happen. _However_, developers can opt out of zone-patching for events in several ways, and often do this for very frequent listeners like `mousemove`, `resize`, and `scroll`. We do not want to break existing expectations that these are now "safe" events to have listeners for by automatically scheduling change detection regardless of whether the listener executed inside or outside the Angular zone. In contrast, in order for developers to more easily transition to zoneless, we need to be able to ensure that components which are using `OnPush` are, for the most part, compatible with zoneless as well. Because listeners automatically mark the component for check, developers using `OnPush` did not/do not need to also call `ChangeDetectorRef.markForCheck` or a similar API. Unfortunately, this means that we need to consider the listener callbacks as a notification to schedule a `tick` when Zoneless is enabled. In the future, we would like to have an opt-out for this (i.e. signal components) since it's not really how we _want_ things to work. Also includes the fix for #54919 that got reverted only because it was easier to revert the set of conflicting commits PR Close #55525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ZoneJS (#55492)
In Angular today, a bound listener automatically marks the view for check. When using ZoneJS, these listeners are most often executed in the Angular Zone as well, so synchronization (
ApplicationRef.tick) will eventually happen. However, developers can opt out of zone-patching for events in several ways, and often do this for very frequent listeners likemousemove,resize, andscroll. We do not want to break existing expectations that these are now "safe" events to have listeners for by automatically scheduling change detection regardless of whether the listener executed inside or outside the Angular zone.In contrast, in order for developers to more easily transition to zoneless, we need to be able to ensure that components which are using
OnPushare, for the most part, compatible with zoneless as well. Because listeners automatically mark the component for check, developers usingOnPushdid not/do not need to also callChangeDetectorRef.markForCheckor a similar API. Unfortunately, this means that we need to consider the listener callbacks as a notification to schedule atickwhen Zoneless is enabled. In the future, we would like to have an opt-out for this (i.e. signal components) since it's not really how we want things to work.Also includes the fix for #54919 that got reverted only because it was easier to revert the set of conflicting commits