build: make scripts for compatibility with Node.js 18.20+ #55527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: lts
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
update-scriot-16
branch
3 times, most recently
from
85e3a01
to
27fc6b3
Compare
This commit enhances the ng-dev and other local scripts to ensure compatibility with Node.js 18.20+. This adjustment is essential for releasing this branch, as it would otherwise lack compatibility with that version. (cherry picked from commit 416d440)
alan-agius4
force-pushed
the
update-scriot-16
branch
from
27fc6b3
to
0227bcb
Compare
Update zone.js typings tests to work
Based on recent discussions, these changes remove the Windows CI check because it has been too flaky for too long. Furthermore, we've concluded that the simulated file system in the compiler tests already catches the same set of bugs as running the tests on a real Windows system. PR Close angular#52140 (cherry picked from commit 5a969e0)
alan-agius4
requested review from
AndrewKushnir
and removed request for
atscott
josephperrott
approved these changes
Apr 25, 2024
josephperrott
approved these changes
Apr 25, 2024
josephperrott
added
action: merge
|
This PR was merged into the repository by commit 56e085f. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 25, 2024
Update zone.js typings tests to work PR Close #55527
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 25, 2024
Based on recent discussions, these changes remove the Windows CI check because it has been too flaky for too long. Furthermore, we've concluded that the simulated file system in the compiler tests already catches the same set of bugs as running the tests on a real Windows system. PR Close #52140 (cherry picked from commit 5a969e0) PR Close #55527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the ng-dev and other local scripts to ensure compatibility with Node.js 18.20+. This adjustment is essential for releasing this branch, as it would otherwise lack compatibility with that version.