New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(compiler-cli): optimize extra import generation in local com… #55548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmvald
force-pushed
the
optimize-lcm-extra-imports
branch
from
April 25, 2024 21:43
48e6d74
to
0fbf375
Compare
pmvald
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
area: compiler
Issues related to `ngc`, Angular's template compiler
target: minor
This PR is targeted for the next minor release
labels
Apr 25, 2024
devversion
approved these changes
Apr 30, 2024
@pmvald can you rebase and mark for merge then? |
devversion
added
action: merge
The PR is ready for merge by the caretaker
action: cleanup
The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Apr 30, 2024
This comment was marked as outdated.
This comment was marked as outdated.
AndrewKushnir
removed
the
action: merge
The PR is ready for merge by the caretaker
label
Apr 30, 2024
FYI, removing the "merge" label for now, please re-add when the PR is ready for merge. |
…pilation mode Currently we add global extra imports to all the files in the compilation unit. However not all the files need extra imports. For example non-Angular files definitely do not need such extra imports, and in some cases these extra imports causes problems as the file is meant to be run the Node but it has Angular dependencies which are not compatible with Node. This change tries to limit extra import generation to a subset of files. Wit hthis change we create extra imports only for the files that contain at least one component whose NgModule is in a different file. This is because all other files do not need extra imports since they are either not Angular files or they already have all the imports that the components need.
pmvald
force-pushed
the
optimize-lcm-extra-imports
branch
from
May 1, 2024 17:40
0fbf375
to
aa83f09
Compare
pmvald
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: cleanup
The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
labels
May 2, 2024
Caretaker note: p1 test failures are tool failures and unrelated to Angular as far as it shows |
pmvald
added
the
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
label
May 2, 2024
AndrewKushnir
added
target: rc
This PR is targeted for the next release-candidate
target: minor
This PR is targeted for the next minor release
and removed
target: minor
This PR is targeted for the next minor release
target: rc
This PR is targeted for the next release-candidate
labels
May 2, 2024
This PR was merged into the repository by commit 1f2e791. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: merge
The PR is ready for merge by the caretaker
area: compiler
Issues related to `ngc`, Angular's template compiler
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
target: minor
This PR is targeted for the next minor release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pilation mode
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information