Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix missing example #55584

Closed
wants to merge 1 commit into from
Closed

docs: fix missing example #55584

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Apr 29, 2024 •
edited

@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 29, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

Deployed adev-preview for 430a040 to: https://ng-dev-previews-fw--pr-angular-angular-55584-adev-prev-c7ijy2tl.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche force-pushed the docs/fix-docs-code-missing-language branch 2 times, most recently from d81690d to d9bca57 Compare April 29, 2024 22:44
@JeanMeche
docs: fix missing example
430a040 
preview is hidding was responsible for hidding the content.

fixes angular#55583
@JeanMeche JeanMeche force-pushed the docs/fix-docs-code-missing-language branch from d9bca57 to 430a040 Compare April 30, 2024 22:30
@JeanMeche JeanMeche marked this pull request as ready for review April 30, 2024 22:32
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels May 1, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 7ff7dfa.

AndrewKushnir pushed a commit that referenced this pull request May 1, 2024
@JeanMeche @AndrewKushnir
docs: fix missing example (#55584)
9aa47c1 
preview is hidding was responsible for hidding the content.

fixes #55583

PR Close #55584
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Missing example code for accessibility best practices case study
2 participants
@JeanMeche @AndrewKushnir