Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Remove IE compatibility code from eventcontract.ts #55585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(core): Remove IE compatibility code from eventcontract.ts #55585

wants to merge 1 commit into from

Conversation

rahatarmanahmed
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

NOTE: I suppose it's breaking for IE but we no longer support them.

Other information

@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 29, 2024
@rahatarmanahmed rahatarmanahmed removed the request for review from neonstalwart April 29, 2024 22:16
@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate area: core Issues related to the framework runtime core: event dispatch labels Apr 30, 2024
@ngbot ngbot bot modified the milestone: Backlog Apr 30, 2024
@rahatarmanahmed rahatarmanahmed added the action: merge The PR is ready for merge by the caretaker label Apr 30, 2024
@rahatarmanahmed rahatarmanahmed removed the action: merge The PR is ready for merge by the caretaker label Apr 30, 2024
@rahatarmanahmed
refactor(core): Remove IE compatibility code from eventcontract.ts
eedf550 
Both of these APIs should be widely available (they're probably even
available in IE11, but we don't care).
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteriani iteriani iteriani approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
area: core Issues related to the framework runtime core: event dispatch requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rahatarmanahmed @iteriani @AndrewKushnir