-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform-browser): Use the right namespace for mathML. #55665
Conversation
yarn.lock
Outdated
@@ -16707,6 +16707,11 @@ typescript@5.4.2: | |||
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.4.2.tgz#0ae9cebcfae970718474fe0da2c090cad6577372" | |||
integrity sha512-+2/g0Fds1ERlP6JsakQQDXjZdZMM+rqpamFZJEKh4kwTIn3iDkgKtby0CeNd5ATNZ4Ry1ax15TMx0W2V+miizQ== | |||
|
|||
typescript@5.4.5: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a cherry-pick woe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a mismatch in the lock file. The 17.3.x
branch is currently red because of this.
fc83ac1
to
dc29633
Compare
95b54e6
to
d23cf3b
Compare
Prior to this change, MathML element were created with the wrong namespace resulting in regular DOM `Element`. This commit fixes this.
This is now in the LTS branch. We could still merge it if you want, but we don't often backport this kind of thing. |
It's probably not worth shipping a patch for this. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Prior to this change, MathML element were created with the wrong namespace resulting in regular DOM
Element
.This commit fixes this.
This is a backport of #55622 into 17.3