Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform-server): remove event dispatch script from HTML when hydration is disabled #55681

Closed

Conversation

alan-agius4
Copy link
Contributor

Prior to this commit, the included event dispatcher remained in the HTML even when hydration was disabled.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 6, 2024
@alan-agius4 alan-agius4 added the area: server Issues related to server-side rendering label May 6, 2024
@ngbot ngbot bot added this to the Backlog milestone May 6, 2024
@alan-agius4 alan-agius4 changed the title fix(platform-server): Eliminate event dispatch script from HTML when hydration is disabled fix(platform-server): remove event dispatch script from HTML when hydration is disabled May 6, 2024
…ration is disabled

Prior to this commit, the included event dispatcher remained in the HTML even when hydration was disabled.
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4 thanks for fixing this issue 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 6, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit cf84acf.

AndrewKushnir pushed a commit that referenced this pull request May 6, 2024
…ration is disabled (#55681)

Prior to this commit, the included event dispatcher remained in the HTML even when hydration was disabled.

PR Close #55681
@alan-agius4 alan-agius4 deleted the event-dispatcher-removal branch May 6, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants