Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-infra): handle rc, next and deprecated versions #55684

Closed

Conversation

9kubczas4
Copy link
Contributor

@9kubczas4 9kubczas4 commented May 6, 2024

fix(docs-infra): handle rc, next and deprecated versions

  • script to generate list of Angular Docs versions
  • remove VersionsManager
  • adjust logic in NavigationComponent

RC pipeline should run script (scripts/version/index.mjs) with following args: node index.mjs version=18 mode=rc, where 18 is stable version.
Next pipeline should run script (scripts/version/index.mjs) with following args: node index.mjs version=18 mode=next, where 18 is stable version.
Stable pipeline should run script (scripts/version/index.mjs) with following args: node index.mjs version=18, where 18 is stable version.

To deprecate previous version i.e 17 we should run script with following args: node index.mj version=17 mode=deprecated

Note: Idk how to run this script in bazel to enable local development, for now adev build is failing due to Cannot find module '../../src/assets/versions.json. CC: @josephperrott @twerske

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • [x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Other information

fix(docs-infra): handle rc, next and deprecated versions
- script to generate list of Angular Docs versions
- remove VersionsManager
- adjust logic in NavigationComponent
fix(docs-infra): handle rc, next and deprecated versions
- script to generate list of Angular Docs versions
- remove VersionsManager
- adjust logic in NavigationComponent
- remove import to VersionManager
@9kubczas4
Copy link
Contributor Author

It was resolved by #55997.

@9kubczas4 9kubczas4 closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant