-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Remove custom event and replay behavior. #55695
refactor(core): Remove custom event and replay behavior. #55695
Conversation
b3cfc77
to
bf00088
Compare
TESTED=TGP |
41bc51d
to
980dd33
Compare
Caretaker note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reviewed-for: public-api, primitives, size-tracking
@@ -219,7 +218,7 @@ describe('dispatcher test.ts', () => { | |||
dispatcher.registerGlobalHandler('click', handler); | |||
|
|||
const eventInfo = createTestEventInfo({ | |||
event: createEvent({type: 'mousedown'} as Event), | |||
event: new MouseEvent('mousedown', {bubbles: true, cancelable: true}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need to add support for Blossom and Buttercup, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
980dd33
to
4549f92
Compare
@tbondwilkinson this PR conflicts with the |
4549f92
to
d7f7985
Compare
d7f7985
to
40f76d0
Compare
Done! |
40f76d0
to
e4b0c88
Compare
These behaviors have been moved back to g3.
e4b0c88
to
40a3d8b
Compare
These behaviors have been moved back to g3. PR Close #55695
This PR was merged into the repository by commit 76d0aea. |
These behaviors have been moved back to g3.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?