refactor(devtools): remove --config snapshot-build and leave a note for Firefox
#55717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Firefox We removed display of the Git SHA in Angular DevTools in angular#55694, so there is no longer a need to stamp release builds in Chrome or Firefox. I opted to leave a `--config snapshot-build-firefox` option as a no-op which a reader could follow to a comment explaining exactly _why_ we can't stamp Firefox releases. This should hopefully make it less likely that we forget and attempt to re-add this feature in the future only to encounter the same release problems.
dgp1130
added
action: review
AleksanderBodurri
approved these changes
May 7, 2024
dgp1130
added
action: merge
|
This PR was merged into the repository by commit eb1af1e. |
atscott
pushed a commit
that referenced
this pull request
May 8, 2024
… for Firefox (#55717) We removed display of the Git SHA in Angular DevTools in #55694, so there is no longer a need to stamp release builds in Chrome or Firefox. I opted to leave a `--config snapshot-build-firefox` option as a no-op which a reader could follow to a comment explaining exactly _why_ we can't stamp Firefox releases. This should hopefully make it less likely that we forget and attempt to re-add this feature in the future only to encounter the same release problems. PR Close #55717
atscott
pushed a commit
that referenced
this pull request
May 8, 2024
… for Firefox (#55717) We removed display of the Git SHA in Angular DevTools in #55694, so there is no longer a need to stamp release builds in Chrome or Firefox. I opted to leave a `--config snapshot-build-firefox` option as a no-op which a reader could follow to a comment explaining exactly _why_ we can't stamp Firefox releases. This should hopefully make it less likely that we forget and attempt to re-add this feature in the future only to encounter the same release problems. PR Close #55717
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed display of the Git SHA in Angular DevTools in #55694, so there is no longer a need to stamp release builds in Chrome or Firefox.
I opted to leave a
--config snapshot-build-firefoxoption as a no-op which a reader could follow to a comment explaining exactly why we can't stamp Firefox releases. This should hopefully make it less likely that we forget and attempt to re-add this feature in the future only to encounter the same release problems.