Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Add four tests and fix code to make tests pass. #55747

Closed
wants to merge 4 commits into from

Commits on May 10, 2024

  1. refactor(core): Add four tests and fix code to make tests pass.

    The first test asserts that bubbling does not work right now.
    
    The second asserts that stopPropagation works, which should pass when test #1 passes too.
    
    The third test asserts properties about the events passed to the event handler.
    
    THe fourth test asserts that mouse events do not translate to jsaction nor help emit the jsaction binary. This required a change in code to make this pass.
    iteriani committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4d9963e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2e56a9a View commit details
    Browse the repository at this point in the history
  3. refactor(core): Simplify event handler extraction logic.

    This reuses information already recorded during hydration to
    remove jsaction attributes to also stash event handlers. This avoids
    a tree walk and looku.
    iteriani committed May 10, 2024
    Configuration menu
    Copy the full SHA
    320bea9 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    5c1eb5e View commit details
    Browse the repository at this point in the history