refactor(forms): Standalone ControlValueAccessor & Validators directives #55758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
forms/default-cva
branch
2 times, most recently
from
4d4ad11
to
bdc3159
Compare
JeanMeche
force-pushed
the
forms/default-cva
branch
from
bdc3159
to
c8d8ff5
Compare
JeanMeche
force-pushed
the
forms/default-cva
branch
from
c8d8ff5
to
e1bd566
Compare
angular-robot
bot
added
detected: feature
JeanMeche
changed the title
DefaultValueAccessor standalone
JeanMeche
force-pushed
the
forms/default-cva
branch
from
e1bd566
to
a53cea7
Compare
Making our control value accessors standalone allows developers to improve composition when writing form-aware components. This is achieved by adding the control value accessors to the host directives.
JeanMeche
force-pushed
the
forms/default-cva
branch
from
a53cea7
to
4f6a5e7
Compare
By making our validator directives standalone, we allow developers to use them as `hostDirectives`. This will improve form composition when writing component libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
The change allows developers to use ControlValueAccessor & Validators directives as host directives.
It doesn't change how Angular forms work. Developer will need to either import the
FormsModuleor theReactiveFormModulewhen dealing with forms.Fixes