Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Add a test case for content projection. #55801

Closed
wants to merge 1 commit into from
Closed

refactor(core): Add a test case for content projection. #55801

wants to merge 1 commit into from

Conversation

iteriani
Copy link
Contributor

This test actually used to fail until our recent improvements :))

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@iteriani
refactor(core): Add a test case for content projection.
eac26d4 
This test actually used to fail until our recent improvements :))
AndrewKushnir
AndrewKushnir approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate core: event dispatch labels May 15, 2024
@ngbot ngbot bot modified the milestone: Backlog May 15, 2024
@atscott
Copy link
Contributor

atscott commented May 15, 2024

This PR was merged into the repository by commit 99bd9f1.

@atscott atscott closed this in 99bd9f1 May 15, 2024
atscott pushed a commit that referenced this pull request May 15, 2024
@iteriani @atscott
refactor(core): Add a test case for content projection. (#55801)
88fb946 
This test actually used to fail until our recent improvements :))

PR Close #55801
iteriani added a commit to iteriani/angular that referenced this pull request May 15, 2024
@iteriani
refactor(core): Add a test case for content projection. (angular#55801)
f334f67 
This test actually used to fail until our recent improvements :))

PR Close angular#55801
iteriani added a commit to iteriani/angular that referenced this pull request May 15, 2024
@iteriani
refactor(core): Add a test case for content projection. (angular#55801)
1bf5d02 
This test actually used to fail until our recent improvements :))

PR Close angular#55801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iteriani @atscott @AndrewKushnir