Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zone.js): correctly bundle zone-patch-rxjs #55826

Closed
wants to merge 1 commit into from
Closed

fix(zone.js): correctly bundle zone-patch-rxjs #55826

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented May 16, 2024 •
edited

#53443 caused the local rxjs file to be imported from an entry-point which caused this to be excluded from being bundled due to the name matching rxjs.

Closes #55825

@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 16, 2024
@pullapprove pullapprove bot requested a review from JiaLiPassion May 16, 2024 11:05
@alan-agius4 alan-agius4 added area: zones target: patch This PR is targeted for the next patch release labels May 16, 2024
@ngbot ngbot bot added this to the Backlog milestone May 16, 2024
@alan-agius4 alan-agius4 force-pushed the rxjs-zone.js branch 2 times, most recently from ab8d1d0 to 75419c4 Compare May 16, 2024 11:24
@alan-agius4
fix(zone.js): correctly bundle zone-patch-rxjs
31fbc9c 
angular#53443 caused the a local `rxjs` file to be imported from an entry-point which caused this to be excluded from being bundled due to the name matching `rxjs`.

Closes angular#55825
alxhub
alxhub approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-approvers

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 16, 2024
@alan-agius4 alan-agius4 removed the request for review from JiaLiPassion May 16, 2024 14:26
@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 16, 2024
@atscott
Copy link
Contributor

atscott commented May 16, 2024

This PR was merged into the repository by commit 20a530a.

atscott pushed a commit that referenced this pull request May 16, 2024
@alan-agius4 @atscott
fix(zone.js): correctly bundle zone-patch-rxjs (#55826)
3055b92 
#53443 caused the a local `rxjs` file to be imported from an entry-point which caused this to be excluded from being bundled due to the name matching `rxjs`.

Closes #55825

PR Close #55826
@atscott atscott closed this in 20a530a May 16, 2024
@alan-agius4 alan-agius4 deleted the rxjs-zone.js branch May 16, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: zones target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Broken zone-patch-rxjs in Zone.js 0.14.5
3 participants
@alan-agius4 @atscott @alxhub