Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(zone.js): remove tslib from dependencies #55827

Closed
wants to merge 1 commit into from
Closed

refactor(zone.js): remove tslib from dependencies #55827

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented May 16, 2024 •
edited

Iif needed tslib code is included directly in the bundled FESM2015 hence making the dependency redundant.

@alan-agius4 alan-agius4 added regression Indicates than the issue relates to something that worked in a previous version area: zones target: patch This PR is targeted for the next patch release labels May 16, 2024
@ngbot ngbot bot added this to the Backlog milestone May 16, 2024
@pullapprove pullapprove bot requested a review from JiaLiPassion May 16, 2024 11:25
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer and removed regression Indicates than the issue relates to something that worked in a previous version labels May 16, 2024
@alan-agius4 alan-agius4 removed the request for review from JiaLiPassion May 16, 2024 11:25
@pullapprove pullapprove bot requested a review from JiaLiPassion May 16, 2024 11:25
@alan-agius4
refactor(zone.js): remove tslib from dependencies
36673cb 
Iif needed `tslib` code is included directly in the bundled FESM2015 hence making the dependency redundant.
alxhub
alxhub approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-approvers

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 16, 2024
@atscott atscott closed this in f3b0e2f May 16, 2024
atscott pushed a commit that referenced this pull request May 16, 2024
@alan-agius4 @atscott
refactor(zone.js): remove tslib from dependencies (#55827)
a768c90 
Iif needed `tslib` code is included directly in the bundled FESM2015 hence making the dependency redundant.

PR Close #55827
atscott pushed a commit that referenced this pull request May 16, 2024
@alan-agius4 @atscott
refactor(zone.js): remove tslib from dependencies (#55827)
349f24a 
Iif needed `tslib` code is included directly in the bundled FESM2015 hence making the dependency redundant.

PR Close #55827
@atscott
Copy link
Contributor

atscott commented May 16, 2024

This PR was merged into the repository by commit f3b0e2f.

@alan-agius4 alan-agius4 deleted the zone.js-deps-tslib branch May 16, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxhub alxhub alxhub approved these changes

@JiaLiPassion JiaLiPassion Awaiting requested review from JiaLiPassion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: zones target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alan-agius4 @atscott @alxhub