fix(zone.js): allow enabling default beforeunload handling
#55875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, when zone.js was included, it wasn't possible to handle `beforeunload` events correctly if event handlers returned strings to prompt the user. With this change, we introduce a global configuration flag, `__zone_symbol__enable_beforeunload`, to allow consumers to enable the default `beforeunload` handling behavior. This flag is necessary to prevent any breaking changes resulting from this modification. The previous attempt to fix it caused a large number of failures in G3. Hence, we're hiding that fix behind the configuration flag. Closes angular#47579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, when zone.js was included, it wasn't possible to handle
beforeunloadevents correctly if event handlers returned strings to prompt the user.With this change, we introduce a global configuration flag,
__zone_symbol__enable_beforeunload, to allow consumers to enable the defaultbeforeunloadhandling behavior.This flag is necessary to prevent any breaking changes resulting from this modification. The previous attempt to fix it caused a large number of failures in G3. Hence, we're hiding that fix behind the configuration flag.
Closes #47579
Closes #52256