-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add angular.dev release banners #56014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎆
<h1 tabindex="-1">Welcome to Angular.dev — the new home for Angular!</h1> | ||
<p class="adev-banner-cta">Read about our launch</p> | ||
<a href="https://goo.gle/angular-v18" class="adev-banner" target="_blank"> | ||
<h1 tabindex="-1">Angular v18 is new available!</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new -> now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for content, though I just now noticed that these banners are <h1>
elements, which I don't think is correct
Deployed adev-preview for 48345d9 to: https://ng-dev-previews-fw--pr-angular-angular-56014-adev-prev-awck2y8i.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
94e8ad2
to
48345d9
Compare
A follow up PR :) |
This PR was merged into the repository by commit 1d774d6. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
v18!!!!!!!!!! wow