Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add angular.dev release banners #56014

Closed
wants to merge 1 commit into from
Closed

docs: add angular.dev release banners #56014

wants to merge 1 commit into from

Conversation

twerske
Copy link
Contributor

@twerske twerske commented May 22, 2024

v18!!!!!!!!!! wow

@twerske twerske added target: patch This PR is targeted for the next patch release area: adev Angular.dev documentation adev: preview labels May 22, 2024
@ngbot ngbot bot modified the milestone: Backlog May 22, 2024
@pullapprove pullapprove bot requested a review from devversion May 22, 2024 21:24
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 22, 2024
JeanMeche
JeanMeche approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

crisbeto
crisbeto previously requested changes May 22, 2024
View reviewed changes
adev/src/app/features/home/home.component.html Outdated
<h1 tabindex="-1">Welcome to Angular.dev &#8212; the new home for Angular!</h1>
<p class="adev-banner-cta">Read about our launch</p>
<a href="https://goo.gle/angular-v18" class="adev-banner" target="_blank">
<h1 tabindex="-1">Angular v18 is new available!</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new -> now

jelbourn
jelbourn approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for content, though I just now noticed that these banners are <h1> elements, which I don't think is correct

@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited

Deployed adev-preview for 48345d9 to: https://ng-dev-previews-fw--pr-angular-angular-56014-adev-prev-awck2y8i.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@twerske twerske requested a review from crisbeto May 22, 2024 21:58
@twerske twerske added the action: merge The PR is ready for merge by the caretaker label May 22, 2024
@ngbot
Copy link

ngbot bot commented May 22, 2024

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing
    pending 3 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@twerske
Copy link
Contributor Author

twerske commented May 22, 2024

LGTM for content, though I just now noticed that these banners are <h1> elements, which I don't think is correct

A follow up PR :)

@twerske twerske requested review from crisbeto and removed request for crisbeto and devversion May 22, 2024 21:59
@twerske twerske dismissed crisbeto’s stale review May 22, 2024 22:08

typo fixed - ready to merge

@dylhunn dylhunn removed the request for review from crisbeto May 22, 2024 22:08
@dylhunn
Copy link
Contributor

dylhunn commented May 22, 2024

This PR was merged into the repository by commit 1d774d6.

dylhunn pushed a commit that referenced this pull request May 22, 2024
@twerske @dylhunn
docs: add angular.dev release banners (#56014)
5d64589 
PR Close #56014
@dylhunn dylhunn closed this in 1d774d6 May 22, 2024
@twerske twerske deleted the adev-release-banner branch May 22, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@JeanMeche JeanMeche JeanMeche approved these changes

@crisbeto crisbeto crisbeto left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: adev Angular.dev documentation area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@twerske @dylhunn @jelbourn @JeanMeche @crisbeto