Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update cross-repo angular dependencies #56041

Closed
wants to merge 2 commits into from
Closed

build: update cross-repo angular dependencies #56041

wants to merge 2 commits into from

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels May 23, 2024
@ngbot ngbot bot added this to the Backlog milestone May 23, 2024
@pkozlowski-opensource pkozlowski-opensource added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 27, 2024
@pkozlowski-opensource
Copy link
Member

@josephperrott looks like this one will need a rebase

@pkozlowski-opensource pkozlowski-opensource removed the action: merge The PR is ready for merge by the caretaker label May 27, 2024
@josephperrott josephperrott force-pushed the pr-takeover-55806 branch 2 times, most recently from a64145f to 236bbcc Compare May 28, 2024 17:47
@angular-robot @josephperrott
build: update cross-repo angular dependencies
f9f447e 
See associated pull request for more information.

Closes angular#55806 as a pr takeover
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 29, 2024
@thePunderWoman thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels May 29, 2024
@thePunderWoman
Copy link
Contributor

Looks like this doesn't cleanly merge into 18.0.x.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels May 29, 2024
@ngbot
Copy link

ngbot bot commented May 29, 2024

I see that you just added the action: merge label, but the following checks are still failing:
聽聽聽聽failure status "mergeability" is failing
聽聽聽聽pending status "google-internal-tests" is pending
聽聽聽聽pending status "pullapprove" is pending
聽聽聽聽pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott requested review from thePunderWoman and removed request for pkozlowski-opensource May 29, 2024 22:25
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 3d55073.

@josephperrott josephperrott deleted the pr-takeover-55806 branch June 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josephperrott @pkozlowski-opensource @thePunderWoman @angular-robot