Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Switch a .includes to a .indexOf(), as this is currently #56046

Closed
wants to merge 1 commit into from
Closed

refactor(core): Switch a .includes to a .indexOf(), as this is currently #56046

wants to merge 1 commit into from

Conversation

iteriani
Copy link
Contributor

breaking internal tests that assert no usage of Array ES6 methods.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@iteriani
refactor(core): Switch a .includes to a .indexOf(), as this is currently
4751d8c 
breaking internal tests that assert no usage of Array ES6 methods.
@pullapprove pullapprove bot requested review from alxhub and Jesse-Good May 23, 2024 16:57
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 23, 2024
@iteriani iteriani requested review from tbondwilkinson and AndrewKushnir and removed request for alxhub and Jesse-Good May 23, 2024 16:57
@pkozlowski-opensource pkozlowski-opensource added the area: core Issues related to the framework runtime label May 27, 2024
@ngbot ngbot bot added this to the Backlog milestone May 27, 2024
@iteriani iteriani added the action: merge The PR is ready for merge by the caretaker label May 29, 2024
@iteriani
Copy link
Contributor Author

TESTED=TGP

@pkozlowski-opensource pkozlowski-opensource added the target: patch This PR is targeted for the next patch release label May 29, 2024
thePunderWoman pushed a commit that referenced this pull request May 30, 2024
@iteriani @thePunderWoman
refactor(core): Switch a .includes to a .indexOf(), as this is curren…
0e3e6d4 
…tly (#56046)

breaking internal tests that assert no usage of Array ES6 methods.

PR Close #56046
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit caeb704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbondwilkinson tbondwilkinson tbondwilkinson approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@Jesse-Good Jesse-Good Jesse-Good approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iteriani @thePunderWoman @tbondwilkinson @AndrewKushnir @Jesse-Good @pkozlowski-opensource