Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add neovim setup section to adev #56057

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shannonvc
Copy link

@shannonvc shannonvc commented May 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

It seems like the language-service Neovim setup was lost in migration from aio to adev.

Issue Number: #56055

What is the new behavior?

Neovim setup section that was in aio was added back to adev.

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from alxhub May 24, 2024 02:31
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 24, 2024
@ngbot ngbot bot added this to the Backlog milestone May 24, 2024
@JeanMeche JeanMeche removed the request for review from alxhub June 12, 2024 21:33
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 12, 2024
Comment on lines 138 to 139
```
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be hard to keep this instruction up-to-date. Would it be possible to have that instruction as a part of one of the mentioned repository and just link to that page?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR currently brings back the page as it existed on aio

That instruction is just extracted from the 2nd link, which is an issue on the coc-angular plugin repo. It seems like that repo isn't really maintained since Angular 16, hence the issue.

I have tried looking for angular instructions in the coc.nvim repository but couldn't find anything.

I can try to find an alternative but it may take a while as I am not familiar with Neovim myself.

Copy link
Author

@shannonvc shannonvc Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed an update which rewrites the Neovim section to use the nvim-lspconfig plugin instead of coc.

It lives under the neovim organization directly. It also allowed me to simply link to their install instruction and angularls configuration pages.

@AndrewKushnir AndrewKushnir removed the action: merge The PR is ready for merge by the caretaker label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants