-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add neovim setup section to adev #56057
base: main
Are you sure you want to change the base?
Conversation
``` | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be hard to keep this instruction up-to-date. Would it be possible to have that instruction as a part of one of the mentioned repository and just link to that page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR currently brings back the page as it existed on aio
That instruction is just extracted from the 2nd link, which is an issue on the coc-angular plugin repo. It seems like that repo isn't really maintained since Angular 16, hence the issue.
I have tried looking for angular instructions in the coc.nvim repository but couldn't find anything.
I can try to find an alternative but it may take a while as I am not familiar with Neovim myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed an update which rewrites the Neovim section to use the nvim-lspconfig plugin instead of coc.
It lives under the neovim organization directly. It also allowed me to simply link to their install instruction and angularls configuration pages.
b1eafa1
to
9ca76ec
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It seems like the language-service Neovim setup was lost in migration from aio to adev.
Issue Number: #56055
What is the new behavior?
Neovim setup section that was in aio was added back to adev.
Does this PR introduce a breaking change?