Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add neovim setup section to adev #56057

Closed
wants to merge 1 commit into from
Closed

docs: add neovim setup section to adev #56057

wants to merge 1 commit into from
+8 −0

Conversation

shannonvc
Copy link
Contributor

@shannonvc shannonvc commented May 24, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

It seems like the language-service Neovim setup was lost in migration from aio to adev.

Issue Number: #56055

What is the new behavior?

Neovim setup section that was in aio was added back to adev.

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from alxhub May 24, 2024 02:31
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 24, 2024
@ngbot ngbot bot added this to the Backlog milestone May 24, 2024
@JeanMeche JeanMeche removed the request for review from alxhub June 12, 2024 21:33
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 12, 2024
@AndrewKushnir AndrewKushnir removed the action: merge The PR is ready for merge by the caretaker label Jun 13, 2024
AndrewKushnir
AndrewKushnir approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shannonvc thanks for updating the PR!

@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Jun 24, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Jun 25, 2024

This PR was merged into the repository by commit 362e3c7.

The changes were merged into the following branches: main, 18.0.x

dylhunn pushed a commit that referenced this pull request Jun 25, 2024
@shannonvc @dylhunn
docs: add neovim setup section to adev (#56057)
cfe1f38 
PR Close #56057
@dylhunn dylhunn closed this in 362e3c7 Jun 25, 2024
@shannonvc shannonvc mentioned this pull request Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shannonvc @dylhunn @JeanMeche @AndrewKushnir