Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(compiler): include public constructor paramters to class properties. #56315

Closed
wants to merge 1 commit into from
Closed

refactor(compiler): include public constructor paramters to class properties. #56315

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Public properties declared in the constructor are part of the public API and we should extract them.

Fixes #56310

@JeanMeche JeanMeche mentioned this pull request Jun 6, 2024
Closed
amayer42
amayer42 reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@amayer42 amayer42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! I didn't really know you could pull in the compiler api from typescript like this until now.

This makes sense to me from what I'm able to glean on how the api works.

@JeanMeche JeanMeche marked this pull request as ready for review June 7, 2024 08:02
@pullapprove pullapprove bot requested a review from AndrewKushnir June 7, 2024 08:02
@JeanMeche JeanMeche added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler labels Jun 10, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 10, 2024
@dylhunn dylhunn self-requested a review June 17, 2024 15:55
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 17, 2024
jelbourn
jelbourn reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs at least one test as well

@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label Jun 18, 2024
@JeanMeche JeanMeche force-pushed the fix/56310-extract-ctor-params branch from 0b8a2a4 to 3d52c76 Compare June 18, 2024 19:05
@JeanMeche
refactor(compiler): include public constructor paramters to class pro…
f28f96c 
…perties.

Public properties declared in the constructor are part of the public API and we should extract them.

Fixes angular#56310
@JeanMeche JeanMeche force-pushed the fix/56310-extract-ctor-params branch from 3d52c76 to f28f96c Compare June 18, 2024 19:06
@JeanMeche
Copy link
Member Author

@jelbourn Of course !
I added a dedicated test.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 10, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from AndrewKushnir July 11, 2024 08:41
@atscott
Copy link
Contributor

atscott commented Jul 15, 2024

This PR was merged into the repository by commit e958fa8.

The changes were merged into the following branches: main, 18.1.x

@atscott atscott closed this in e958fa8 Jul 15, 2024
atscott pushed a commit that referenced this pull request Jul 15, 2024
@JeanMeche @atscott
refactor(compiler): include public constructor paramters to class pro…
bbe655f 
…perties. (#56315)

Public properties declared in the constructor are part of the public API and we should extract them.

Fixes #56310

PR Close #56315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelbourn jelbourn jelbourn left review comments

@amayer42 amayer42 amayer42 left review comments

@dylhunn dylhunn dylhunn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Some public APIs are not properly displayed in Angular.dev
5 participants
@JeanMeche @atscott @jelbourn @amayer42 @dylhunn