Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): missing space in zoneless warning #56491

Closed
wants to merge 1 commit into from
Closed

refactor(core): missing space in zoneless warning #56491

wants to merge 1 commit into from

Conversation

arturovt
Copy link
Contributor

There's currently a missing space in the zoneless warning, showing words together.

@pullapprove pullapprove bot requested a review from dylhunn June 18, 2024 14:39
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 18, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 18, 2024
@JeanMeche
Copy link
Member

Thanks for the change, can you pleasemake this a refactor commit as fix commit do appear in the change logs.

@arturovt
refactor(core): missing space in zoneless warning
0549925 
There's currently a missing space in the zoneless warning, showing words together.
@arturovt arturovt changed the title fix(core): missing space in zoneless warning refactor(core): missing space in zoneless warning Jun 18, 2024
@AndrewKushnir AndrewKushnir removed the request for review from dylhunn June 19, 2024 21:06
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jun 19, 2024
@AndrewKushnir
Copy link
Contributor

Caretaker note: no presubmit required, low risk (error message text only) change.

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 39df5fa.

The changes were merged into the following branches: main, 18.0.x

AndrewKushnir pushed a commit that referenced this pull request Jun 20, 2024
@arturovt @AndrewKushnir
refactor(core): missing space in zoneless warning (#56491)
284705f 
There's currently a missing space in the zoneless warning, showing words together.

PR Close #56491
@arturovt arturovt deleted the fix/zoneless-typo branch June 20, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arturovt @JeanMeche @AndrewKushnir