refactor(compiler-cli): support running JIT transforms as part of tsickle emit #56520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckle emit When running the JIT transforms in 1P w/ tsickle, tsickle will transform source files before our custom transforms can run. This is also impacting the Ivy transform and hence we use `ts.getOriginalNode` in various places to inspect the source AST for detecting Angular. For the JIT transform we need to do a similar change so that the transform could run in 1P.
devversion
added
action: review
crisbeto
approved these changes
Jun 19, 2024
devversion
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ckle emit (#56520) When running the JIT transforms in 1P w/ tsickle, tsickle will transform source files before our custom transforms can run. This is also impacting the Ivy transform and hence we use `ts.getOriginalNode` in various places to inspect the source AST for detecting Angular. For the JIT transform we need to do a similar change so that the transform could run in 1P. PR Close #56520
|
This PR was merged into the repository by commit 2d8a96b. The changes were merged into the following branches: main, 18.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the JIT transforms in 1P w/ tsickle, tsickle will transform source files before our custom transforms can run. This is also impacting the Ivy transform and hence we use
ts.getOriginalNodein various places to inspect the source AST for detecting Angular.For the JIT transform we need to do a similar change so that the transform could run in 1P.