Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Style Guide: Sorting class members: section on sorting convention for class members #56521

Closed
wants to merge 1 commit into from

Conversation

engineerpavel
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

In the documentation, in the codestyle section, there is no information about the accepted agreement for sorting class members.

What is the new behavior?

In the codestyle section, information appears about the accepted convention for sorting class members

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link

google-cla bot commented Jun 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from crisbeto June 19, 2024 17:31
@JeanMeche
Copy link
Member

Hi,

Thank you for suggesting improvements to the style guide.
The guide is currently being rewritten, so we're not accepting changes at the time.
Thank you for your understanding

@JeanMeche JeanMeche closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants