Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundles): don't pre-append polyffils to angular2.js bundle #5881

Closed
wants to merge 1 commit into from
Closed

fix(bundles): don't pre-append polyffils to angular2.js bundle #5881

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

BREAKING CHANGE:

Previously angular2.js, angular2.min.js and angular2.dev.js bundles
would have zone.js and reflect-metadata pre-appended. New bundles don't
contain zone.js nor reflect-metadata - those external dependencies can
be easily loaded into a browser using angular2-polyfills.js

@pkozlowski-opensource
Copy link
Member Author

@IgorMinar @wardbell this is a breaking change for all SystemJS users / demo plunks. Let's NOT merge it if there are any concerns about changing things at this point of time.

@jeffbcross
Copy link
Contributor

commit message typo: s/polyffils/polyfills. And I think it would be better expressed as "remove polyfills from angular2.js bundle"

@jeffbcross jeffbcross self-assigned this Dec 14, 2015
@jeffbcross
Copy link
Contributor

I'm reviewing and making sure this bundles correctly, and will let @IgorMinar have the final review.

@jeffbcross jeffbcross added pr_state: LGTM action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 14, 2015
@jeffbcross jeffbcross assigned IgorMinar and unassigned jeffbcross Dec 14, 2015
@jeffbcross jeffbcross added this to the beta.0 milestone Dec 14, 2015
@pkozlowski-opensource
Copy link
Member Author

Hmm, it looks like web-worker bundles are also containing zone.js and reflect-metadata....

@IgorMinar
Copy link
Contributor

lgtm, CI failing due to what looks like a legit failure - I restarted the job just in case. Here are the current failures:

>> http://localhost:8001/bundle/angular2-polyfills.js 337:12 Uncaught TypeError: Cannot redefine property: onclick
>> http://localhost:8001/angular2/core 0:0 Failed to load resource: the server responded with a status of 404 (Not Found)
>> http://localhost:8001/angular2/platform/worker_render 0:0 Failed to load resource: the server responded with a status of 404 (Not Found)
>> http://localhost:8001/bundle/web_worker/ui.dev.js 1507:16 Error: XHR error (404 Not Found) loading http://localhost:8001/angular2/core
    Error loading http://localhost:8001/angular2/core as "angular2/core" from http://localhost:8001/playground/src/web_workers/todo/index.js
F...
Failures:
1) WebWorkers Kitchen Sink should greet
  Message:
    Failed: Waiting for element to be located By.cssSelector("hello-app .greeting")
    Wait timed out after 15012ms
  Stack:
    Error: Waiting for element to be located By.cssSelector("hello-app .greeting")
    Wait timed out after 15012ms
        at Array.forEach (native)
        at process._tickCallback (node.js:366:9)
    From: Task: Waiting for element to be located By.cssSelector("hello-app .greeting")
        at Object.<anonymous> (playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts:17:13)
    From: Task: Run it("should greet") in control flow
        at attemptAsync (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1819:24)
        at QueueRunner.run (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1774:9)
        at QueueRunner.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1762:10)
        at Spec.Env.queueRunnerFactory (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:627:35)
        at Spec.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:353:10)
        at Object.fn (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:2360:37)
        at attemptAsync (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1819:24)
        at QueueRunner.run (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1774:9)
        at QueueRunner.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1762:10)
    From asynchronous test: 
    Error
        at Suite.<anonymous> (playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts:12:3)
        at addSpecsToSuite (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:743:25)
        at Env.describe (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:713:7)
        at jasmineInterface.describe (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:3219:18)
        at Object.<anonymous> (playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts:4:1)
  Message:
    Expected 4 to equal 0.
  Stack:
    Error: Failed expectation
        at angular2/src/testing/e2e_util.ts:21:32
        at Array.forEach (native)
        at process._tickCallback (node.js:366:9)
2) WebWorkers Kitchen Sink should change greeting
  Message:
    Failed: Waiting for element to be located By.cssSelector("hello-app .greeting")
    Wait timed out after 15005ms
  Stack:
    Error: Waiting for element to be located By.cssSelector("hello-app .greeting")
    Wait timed out after 15005ms
        at Array.forEach (native)
        at process._tickCallback (node.js:366:9)
    From: Task: Waiting for element to be located By.cssSelector("hello-app .greeting")
        at Object.<anonymous> (playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts:27:13)
    From: Task: Run it("should change greeting") in control flow
        at attemptAsync (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1819:24)
        at QueueRunner.run (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1774:9)
        at QueueRunner.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1762:10)
        at Spec.Env.queueRunnerFactory (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:627:35)
        at Spec.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:353:10)
        at Object.fn (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:2360:37)
        at attemptAsync (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1819:24)
        at QueueRunner.run (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1774:9)
        at /home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1801:16
    From asynchronous test: 
    Error
        at Suite.<anonymous> (playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts:22:3)
        at addSpecsToSuite (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:743:25)
        at Env.describe (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:713:7)
        at jasmineInterface.describe (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:3219:18)
        at Object.<anonymous> (playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts:4:1)
  Message:
    Expected 4 to equal 0.
  Stack:
    Error: Failed expectation
        at angular2/src/testing/e2e_util.ts:21:32
        at Array.forEach (native)
        at process._tickCallback (node.js:366:9)
3) WebWorkers Kitchen Sink should display correct key names
  Message:
    Failed: Waiting for element to be located By.cssSelector(".sample-area")
    Wait timed out after 15003ms
  Stack:
    Error: Waiting for element to be located By.cssSelector(".sample-area")
    Wait timed out after 15003ms
        at Array.forEach (native)
        at process._tickCallback (node.js:366:9)
    From: Task: Waiting for element to be located By.cssSelector(".sample-area")
        at Object.<anonymous> (playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts:38:13)
    From: Task: Run it("should display correct key names") in control flow
        at attemptAsync (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1819:24)
        at QueueRunner.run (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1774:9)
        at QueueRunner.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1762:10)
        at Spec.Env.queueRunnerFactory (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:627:35)
        at Spec.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:353:10)
        at Object.fn (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:2360:37)
        at attemptAsync (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1819:24)
        at QueueRunner.run (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1774:9)
        at /home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1801:16
    From asynchronous test: 
    Error
        at Suite.<anonymous> (playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts:34:3)
        at addSpecsToSuite (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:743:25)
        at Env.describe (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:713:7)
        at jasmineInterface.describe (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:3219:18)
        at Object.<anonymous> (playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts:4:1)
  Message:
    Expected 4 to equal 0.
  Stack:
    Error: Failed expectation
        at angular2/src/testing/e2e_util.ts:21:32
        at Array.forEach (native)
        at process._tickCallback (node.js:366:9)
4) MessageBroker should bootstrap
  Message:
    Failed: Waiting for element to be located By.cssSelector("app h1")
    Wait timed out after 15000ms
  Stack:
    Error: Waiting for element to be located By.cssSelector("app h1")
    Wait timed out after 15000ms
        at Array.forEach (native)
        at process._tickCallback (node.js:366:9)
    From: Task: Waiting for element to be located By.cssSelector("app h1")
        at waitForBootstrap (playground/e2e_test/web_workers/message_broker/message_broker_spec.ts:38:11)
        at Object.<anonymous> (playground/e2e_test/web_workers/message_broker/message_broker_spec.ts:17:5)
    From: Task: Run it("should bootstrap") in control flow
        at attemptAsync (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1819:24)
        at QueueRunner.run (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1774:9)
        at QueueRunner.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1762:10)
        at Spec.Env.queueRunnerFactory (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:627:35)
        at Spec.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:353:10)
        at Object.fn (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:2360:37)
        at attemptAsync (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1819:24)
        at QueueRunner.run (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1774:9)
        at QueueRunner.execute (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1762:10)
    From asynchronous test: 
    Error
        at Suite.<anonymous> (playground/e2e_test/web_workers/message_broker/message_broker_spec.ts:13:3)
        at addSpecsToSuite (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:743:25)
        at Env.describe (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:713:7)
        at jasmineInterface.describe (/home/travis/build/angular/angular/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:3219:18)
        at Object.<anonymous> (playground/e2e_test/web_workers/message_broker/message_broker_spec.ts:6:1)
  Message:
    Expected 4 to equal 0.
  Stack:
    Error: Failed expectation
        at angular2/src/testing/e2e_util.ts:21:32
        at Array.forEach (native)
        at process._tickCallback (node.js:366:9)

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 14, 2015
@pkozlowski-opensource
fix(bundles): remove polyfills from angular2.js bundle
e6f3025 
BREAKING CHANGE:

Previously `angular2.js`, `angular2.min.js` and `angular2.dev.js` bundles
would have zone.js and reflect-metadata pre-appended. New bundles don't
contain zone.js nor reflect-metadata - those external dependencies can
be easily loaded into a browser using `angular2-polyfills.js`
@pkozlowski-opensource pkozlowski-opensource removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 14, 2015
@pkozlowski-opensource
Copy link
Member Author

@IgorMinar TravisCI is green after I have removed zone + reflect-metadata from web-worker bundles.

Are we making the big jump?

@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Dec 14, 2015
@pkozlowski-opensource
Copy link
Member Author

@alexeagle - Igor says "stick the merge label" and I'm obeying :-) Let's get this one in

@mary-poppins
Copy link

Merging PR #5881 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5881.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pkozlowski-opensource pkozlowski-opensource

Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
beta.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pkozlowski-opensource @jeffbcross @IgorMinar @mary-poppins @alexeagle @googlebot