build(router): refactor angular1 router build script #6821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| fs.writeFileSync(dist + '/angular_1_router.js', main()); | ||
| fs.writeFileSync(outputDirectory + '/angular_1_router.js', main(modulesDirectory)); |
There was a problem hiding this comment.
I think in google3 it is easier to give the path to the output file rather than the output directory, but it complicates your directory creation above. Should we make the CL that uses this before committing, so we are sure it will work?
There was a problem hiding this comment.
Yes, but FWIW, I'm not opposed to providing the path to the file.
jelbourn
added
the
action: cleanup
|
will send you a PR that works better in g3 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.