Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: feat(animations): introduce animation support for angular2 #7698

Closed
wants to merge 2 commits into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Mar 21, 2016

DO NOT MERGE

export {BrowserDetails} from './src/animate/browser_details';
export {CssAnimationBuilder} from './src/animate/css_animation_builder';
export {CssAnimationOptions} from './src/animate/css_animation_options';
export * from 'angular2/src/animate/module';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge animate/module into this file

export class AnimationCompiler {
constructor() {}

_resolveDefaultPropertyMeasurement(prop): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move normalization into an AnimationParser in file modules/src/compiler/animation/animation_parser

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably get a top level method

@@ -0,0 +1,45 @@
import {isPresent} from 'angular2/src/facade/lang';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move into compiler/animation/animation_event

@matsko matsko force-pushed the ng_animate_squashed branch 2 times, most recently from 85a68b4 to a5a237e Compare April 26, 2016 07:20
@@ -0,0 +1,14 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are merging animation with core, compiler and platform-browser so there will be no @angular/animate package.

@mhevery mhevery assigned mhevery and unassigned mprobst May 17, 2016
@matsko
Copy link
Contributor Author

matsko commented May 19, 2016

Replaced by #8734. (There is too much going on on this page.)

@matsko matsko closed this May 19, 2016
@matsko matsko deleted the ng_animate_squashed branch November 14, 2016 21:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants