New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: feat(animations): introduce animation support for angular2 #7698
Conversation
export {BrowserDetails} from './src/animate/browser_details'; | ||
export {CssAnimationBuilder} from './src/animate/css_animation_builder'; | ||
export {CssAnimationOptions} from './src/animate/css_animation_options'; | ||
export * from 'angular2/src/animate/module'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge animate/module
into this file
0bc6360
to
0617bf4
Compare
export class AnimationCompiler { | ||
constructor() {} | ||
|
||
_resolveDefaultPropertyMeasurement(prop): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move normalization into an AnimationParser
in file modules/src/compiler/animation/animation_parser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably get a top level method
@@ -0,0 +1,45 @@ | |||
import {isPresent} from 'angular2/src/facade/lang'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move into compiler/animation/animation_event
a2d082b
to
2423ee4
Compare
85a68b4
to
a5a237e
Compare
a46a711
to
03db352
Compare
@@ -0,0 +1,14 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are merging animation with core
, compiler
and platform-browser
so there will be no @angular/animate
package.
Replaced by #8734. (There is too much going on on this page.) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
DO NOT MERGE