Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RouterLink): ignore optional parameters when checking for active … #7834

Closed
wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Mar 30, 2016

…routes

A bug fix

  • What is the current behavior? (You can also link to an open issue here)

When the URL has query parameters, the RouterLink directive would not mark the link as active (adding a CSS class)

  • What is the new behavior (if this is a feature change)?

The class is added regardless there are query parameters

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

fixes #6459

@btford
Copy link
Contributor

btford commented Mar 30, 2016

LGTM

@mary-poppins
Copy link

Merging PR #7834 on behalf of @alxhub to branch presubmit-alxhub-pr-7834.

@mhevery mhevery closed this in 5e2bc5c Apr 7, 2016
mircoba pushed a commit to mircoba/angular that referenced this pull request Apr 10, 2016
@vicb vicb deleted the 0329-routeName branch June 23, 2016 17:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router Link does not remain active with optional parameters
5 participants